linux-kernel - Re: [PATCH] VM: vm_ops->fault takes explicit struct file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4812DA93.6020707@s5r6.in-berlin.de>
Date:	Sat, 26 Apr 2008 09:32:35 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	Erez Zadok <ezk@...sunysb.edu>
CC:	hch@...radead.org, viro@....linux.org.uk,
	akpm@...ux-foundation.org, krh@...hat.com, airlied@...ux.ie,
	rolandd@...co.com, James.Bottomley@...senPartnership.com,
	hjk@...utronix.de, vandrove@...cvut.cz, mfasheh@...e.com,
	hugh@...itas.com, perex@...ex.cz, avi@...ranet.com,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] VM: vm_ops->fault takes explicit struct file

Erez Zadok wrote:
> For convenience of review and bisectability, I present the changes as one
> patch here.  If desired, I can split it for each subsystem.

Hmm, a split patch won't be useful; it won't compile.

Besides, this change doesn't look too intrusive to me.  For example, 
changes like this...

[...]
> --- a/drivers/ieee1394/dma.c
> +++ b/drivers/ieee1394/dma.c
> @@ -232,7 +232,7 @@ void dma_region_sync_for_device(struct dma_region *dma, unsigned long offset,
>  #ifdef CONFIG_MMU
>  
>  static int dma_region_pagefault(struct vm_area_struct *vma,
> -				struct vm_fault *vmf)
> +				struct vm_fault *vmf, struct file *file)
>  {
>  	struct dma_region *dma = (struct dma_region *)vma->vm_private_data;
>  

...are unlikely to cause objections or merge rejects.  ACK from me for 
the ieee1394 part, FWIW.

PS:  It's an obscure and unimportant fact, but you are not required to 
Cc krh on changes in drivers/ieee1394; he is interested in 
drivers/firewire which is separate code.
-- 
Stefan Richter
-=====-==--- -=-- ==-=-
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/