linux-kernel - Re: [PATCH] ps3disk: Remove superfluous cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080427103534.GU12774@kernel.dk>
Date:	Sun, 27 Apr 2008 12:35:34 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Christoph Hellwig <hch@....de>,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Cell Broadband Engine OSS Development 
	<cbe-oss-dev@...abs.org>
Subject: Re: [PATCH] ps3disk: Remove superfluous cast

On Wed, Apr 23 2008, Geert Uytterhoeven wrote:
> As ps3disk is a ppc64-only driver, sector_t equals to unsigned long, and the
> cast is not needed.
> 
> Reuse in another (possibly 32-bit) driver is protected by the safety net called
> `compiler warning' (with the cast, it may silently truncate to 32-bit).
> If sector_t ever changes, we will get a compiler warning as well (with the
> cast, we won't).
> 
> Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven@...ycom.com>
> Acked-by: Christoph Hellwig <hch@....de>
> ---
> Please apply, thx!

Applied

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/