linux-kernel - [PATCH] xfs: reduce stack usage in xfs_page_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804270246.58828.vda.linux@googlemail.com>
Date:	Sun, 27 Apr 2008 02:46:58 +0200
From:	Denys Vlasenko <vda.linux@...glemail.com>
To:	David Chinner <dgc@....com>
Cc:	xfs@....sgi.com, Eric Sandeen <sandeen@...deen.net>,
	Adrian Bunk <bunk@...nel.org>, linux-kernel@...r.kernel.org
Subject: [PATCH] xfs: reduce stack usage in xfs_page_state_convert()

Hi David,

This patch reduces xfs_page_state_convert() stack usage by 16 bytes
by eliminating some local variables, and reducing the size
of scope for other locals.

Compile tested only.

Signed-off-by: Denys Vlasenko <vda.linux@...glemail.com>

P.S.

xfs_page_state_convert() carries the following comment:
 * Calling this without startio set means we are being asked to make a dirty
 * page ready for freeing it's buffers.  When called with startio set then
 * we are coming from writepage.
which leads to the following proposal: reimplement it as two
functions, one which work as if startio parameter == 0
and the other as if startio == 1.
This will result in a bit of code duplication, but reduces
stack usage on writepage path and allows for these two functions
to have more descriptive names. (Presently the meaning of this
function needs to be explained in that comment -> function
name is not descriptive enough, because it does different things
depending on startio value).

Do you like this idea?
--
vda

View attachment "stk2.diff" of type "text/x-diff" (2478 bytes)