linux-kernel - Re: [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <386072610804270652m7b3c35eubc7c4b2ae5a929a7@mail.gmail.com>
Date:	Sun, 27 Apr 2008 21:52:22 +0800
From:	"Bryan Wu" <cooloney@...nel.org>
To:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
Cc:	khali@...ux-fr.org, andre@...wigglers.org,
	linux-input@...r.kernel.org, i2c@...sensors.org,
	linux-kernel@...r.kernel.org, vapier.adi@...il.com,
	"Michael Hennerich" <michael.hennerich@...log.com>
Subject: Re: [PATCH 1/1] Input/Joystick Driver: add support AD7142 joystick driver (v2)

On Fri, Apr 25, 2008 at 11:39 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
>
> On Fri, Apr 25, 2008 at 06:09:52PM +0800, Bryan Wu wrote:
>  > On Sat, Apr 19, 2008 at 1:15 AM, Dmitry Torokhov
>  > <dmitry.torokhov@...il.com> wrote:
>  > > Hi Bryan,
>  > >
>  > >
>  > >  On Thu, Mar 27, 2008 at 11:38:30AM -0700, Bryan Wu wrote:
>  > >  > +     input->keybit[BIT_WORD(BTN_BASE)] = BIT_MASK(BTN_BASE) |
>  > >  > +                                             BIT_MASK(BTN_BASE2) |
>  > >  > +                                             BIT_MASK(BTN_BASE3) |
>  > >  > +                                             BIT_MASK(BTN_BASE4);
>  > >  > +     input->keybit[BIT_WORD(KEY_UP)] |=  BIT_MASK(KEY_UP) |
>  > >  > +                                             BIT_MASK(KEY_DOWN) |
>  > >  > +                                             BIT_MASK(KEY_LEFT) |
>  > >  > +                                             BIT_MASK(KEY_RIGHT);
>  > >  > +
>  > >
>  > >  Why don't you use REL_X/REL_Y to report directional movement? Using
>  > >  buttons for that is pretty unusual.
>  > >
>  >
>  > In our development board, it includes UP/DOWN/LEFT/RIGHT 4 buttons. So
>  > this driver matches this.
>  > Please found some information about the hardware as below:
>  > http://docs.blackfin.uclinux.org/doku.php?id=capacitance_touch_sensors&s[]=ad7142
>
>  What is the expected behaviur when a person touches one of these
>  buttons? Is it generatig a left/rigth mouse button clocks or moving a
>  pointer in some direction? Judging by the category of the devices you
>  are placing it in (joystick) it seems that latter is what you want,
>  therefore it should generate REL_X and REL_Y events. Otherwise it
>  should probably be called a button driver and live either in
>  drivers/input/keyboard or driver/input/misc. Do you agree?
>

AD7142 is a chip for input devices over i2c interface. So it can be a
joystick, joypad or other input devices.
And this driver is an example for real product driver developers.

Maybe drivers/input/misc is OK for this driver.

Thanks
-Bryan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/