| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sun, 27 Apr 2008 13:38:27 -0700 From: Harvey Harrison <harvey.harrison@...il.com> To: Al Viro <viro@...IV.linux.org.uk> Cc: Linus Torvalds <torvalds@...ux-foundation.org>, Ingo Molnar <mingo@...e.hu>, Andrew Morton <akpm@...ux-foundation.org>, LKML <linux-kernel@...r.kernel.org>, linux-sparse@...r.kernel.org Subject: Re: [PATCH] bitops: simplify generic bit finding functions On Sun, 2008-04-27 at 21:36 +0100, Al Viro wrote: > On Sun, Apr 27, 2008 at 01:29:21PM -0700, Harvey Harrison wrote: > > > Oh, I didn't realize, I only did this because sparse started spewing out > > lots of: > > include/linux/bitops.h:166:32: warning: shift too big (65536) for type unsigned long > > > > due to shift by size there, and again on line 202...I just wanted something > > that sparse wouldn't warn about and was a little easier to understand to boot. > > That's a sparse problem, really. I wonder if we simply should introduce a > new node type: EXPR_WARN. So that expand would generate those from things > like division by zero/overflow/bad shift *and* emitting an insn for those > would generate a stored warning. Well, even though it is a sparse problem, I think my revised version was cleaner code anyway. > > Objections? None here Harvey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists