linux-kernel - Re: [patch] x86, voyager: fix ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <481504BA.4090402@zytor.com>
Date:	Sun, 27 Apr 2008 15:56:58 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jeff Garzik <jeff@...zik.org>
CC:	David Miller <davem@...emloft.net>,
	James.Bottomley@...senPartnership.com, mingo@...e.hu,
	tglx@...utronix.de, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org
Subject: Re: [patch] x86, voyager: fix ioremap_nocache()

Jeff Garzik wrote:
> 
> Understood.
> 
> I guess I am more annoyed that this stealth semantics change appears to 
> have broken everything that depends on pci_iomap(), including 90%+ of 
> all libata drivers, unless I am missing something.
> 
> That one piece of code (pci_iomap) was correct under the old semantics, 
> on x86 and elsewhere.  It's tested and working nicely, and depended upon 
> by many drivers.
> 

That one piece of code has had no effective change.  Under both the old 
and the new code, both branches functionally because ioremap_nocache(), 
in one case because of MTRR and in one case because of PAT.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/