linux-kernel - Re: Breakage caused by unreviewed patch in x86 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080427160711.2b61f592@laptopd505.fenrus.org>
Date:	Sun, 27 Apr 2008 16:07:11 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	David Miller <davem@...emloft.net>
Cc:	James.Bottomley@...senPartnership.com, mingo@...e.hu,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: Breakage caused by unreviewed patch in x86 tree

On Sun, 27 Apr 2008 16:00:41 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Arjan van de Ven <arjan@...radead.org>
> Date: Sun, 27 Apr 2008 15:58:03 -0700
> 
> > On Sun, 27 Apr 2008 16:51:25 -0400
> > James Bottomley <James.Bottomley@...senPartnership.com> wrote:
> > 
> > > This patch:
> > > 
> > > commit 6371b495991debfd1417b17c2bc4f7d7bae05739
> > > Author: Ingo Molnar <mingo@...e.hu>
> > > Date:   Wed Jan 30 13:33:40 2008 +0100
> > > 
> > >     x86: change ioremap() to default to uncached
> > > 
> > > As far as I can tell went blindly into the x86 tree without being
> > > shared on any mailing list at all.  How can something that
> > > completely alters the semantics of ioremap on x86 platforms go in
> > > without any review.
> > 
> > it changed from "whatever coinflip you got" to "predictable
> > outcome". 
> 
> You're making technical responses to a question about process.

ok on a process side it is basically a "go from 99.9% to 100%" bugfix ;(

Anyone who claims that ioremap() on x86 was cached before doesn't understand the issue,
it was NOT cached. It was "almost always uncached". The bugfix here is to take away the
"almost" part.
Should that have been posted to lkml more vocally? Wouldn't have hurt. No argument about that.
Is it as big a deal as this thread makes it sound? Absolutely not! The change in behavior
or even semantics is almost zero.  


-- 
If you want to reach me at my work email, use arjan@...ux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/