linux-kernel - Re: [PATCH] iwlwifi: Fix build error in v2.6.25-5561-g064922a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080427.233507.261574307.davem@davemloft.net>
Date:	Sun, 27 Apr 2008 23:35:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	crmafra2@...il.com
Cc:	linux-kernel@...r.kernel.org, reinette.chatre@...el.com,
	linville@...driver.com, torvalds@...ux-foundation.org
Subject: Re: [PATCH] iwlwifi: Fix build error in v2.6.25-5561-g064922a

From: "Carlos R. Mafra" <crmafra2@...il.com>
Date: Mon, 28 Apr 2008 02:47:01 -0300

> I've just tried to compile v2.6.25-5561-g064922a and it failed with
> these messages:

Already fixed in net-2.6 by:

commit bd8fd21dfddf51299d782f598cb776b15b7d64cc
Author: Luca Tettamanti <kronos.it@...il.com>
Date:   Sun Apr 27 15:34:55 2008 -0700

    wireless: Fix compile error with wifi & leds
    
    Fix build error caused by commit
    e82404ad612ebabc65d15c3d59b971cb35c3ff36 ("iwlwifi: Select
    LEDS_CLASS.") from David Miller:
    
    Since MAC80211_LEDS is selected by wireless drivers it must select its
    own dependencies otherwise a build error may occur (kbuild will select
    the symbol regardless of "depends" constraints).
    
    Signed-off-By: Luca Tettamanti <kronos.it@...il.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/net/mac80211/Kconfig b/net/mac80211/Kconfig
index 520a518..a24b459 100644
--- a/net/mac80211/Kconfig
+++ b/net/mac80211/Kconfig
@@ -73,7 +73,9 @@ config MAC80211_MESH
 
 config MAC80211_LEDS
 	bool "Enable LED triggers"
-	depends on MAC80211 && LEDS_TRIGGERS
+	depends on MAC80211
+	select NEW_LEDS
+	select LEDS_TRIGGERS
 	---help---
 	  This option enables a few LED triggers for different
 	  packet receive/transmit events.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/