lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 28 Apr 2008 10:16:35 +0200 From: "Luca Tettamanti" <kronos.it@...il.com> To: "Adrian Bunk" <bunk@...nel.org> Cc: linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org, "David S. Miller" <davem@...emloft.net> Subject: Re: [PATCH] Fix compile error with wifi & leds On Mon, Apr 28, 2008 at 9:54 AM, Adrian Bunk <bunk@...nel.org> wrote: > On Mon, Apr 28, 2008 at 10:45:31AM +0300, Adrian Bunk wrote: > > Can you send the .config that gives this problem? Just select IWL4965_LEDS without enabling LEDS_TRIGGERS. > Scrap that, I already got the problem (and your patch looks right). It works, yes - but I don't like it... NEW_LEDS enables the core code of the leds driver but also enables/disables the compilation of the whole driver/leds directory; *every* user of the led driver has to select whatever config option it wants (e.g. LEDS_TRIGGERS) _plus_ NEW_LEDS, otherwise led code won't be compiled. >From a quick inspection RT2{4,5}00PCI_LEDS (driver/net/wireless/rt2x00) have the same problem, they select LEDS_CLASS without enabling NEW_LEDS -> unresolved symbols :| Maybe LEDS_* should also select NEW_LEDS? Luca -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists