linux-kernel - Re: [PATCH] eventfd, signalfd, timerfd, epoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0804271703470.18184@alien.or.mcafeemobile.com>
Date:	Sun, 27 Apr 2008 17:07:29 -0700 (PDT)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	Ulrich Drepper <drepper@...hat.com>
cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] eventfd, signalfd, timerfd, epoll_create w/flags

On Sun, 27 Apr 2008, Ulrich Drepper wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Davide Libenzi wrote:
> 
> > Ok, I asked this myself for about ten minutes, than I gave up. But why 
> > sys_epoll_createp() instead of sys_epoll_create2()? There MUST be a reason 
> > to deviate from the standard of all the other ones...
> 
> I used the number at the end for syscalls which aren't visible at
> userlevel.  There they are useful indicating the number of arguments.
> At userlevel I personally find it less than optimal but I'd have no
> problem changing it to epoll_create2.

I think that an ending '2' at least has the logic behind of telling the 
number of parameters. A 'p' really doesn't say anything.
So it's either gonna be something like epoll_create_flags() or 
epoll_create2(). And between the two, I'd personally pick the latter.



- Davide


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/