linux-kernel - Re: [PATCH] x86: vget_cycles() __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080428152422.GD18776@elte.hu>
Date:	Mon, 28 Apr 2008 17:24:22 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Hugh Dickins <hugh@...itas.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: vget_cycles() __always_inline


* Hugh Dickins <hugh@...itas.com> wrote:

> Mark vget_cycles() as __always_inline, so gcc is never tempted to make 
> the vsyscall vread_tsc() dive into kernel text, with resulting 
> SIGSEGV.
> 
> This was a self-inflicted wound: I've not seen that happen with 
> unhacked sources; but for debug reasons I'd changed my x86/Makefile to 
> compile no-unit-at-a-time, and that in conjunction with 
> OPTIMIZE_INLINING=y ended up with vget_cycles() in kernel text.  
> Perhaps it can happen in other ways: safer to use __always_inline.

applied, thanks Hugh - i agree that this is worth fixing.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/