linux-kernel - Re: [PATCH] Fix calculus of bitmap_scnprintf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <481604BD.7000009@sgi.com>
Date:	Mon, 28 Apr 2008 10:09:17 -0700
From:	Mike Travis <travis@....com>
To:	Paul Jackson <pj@....com>
CC:	WANG Cong <xiyou.wangcong@...il.com>, bert.wesarg@...glemail.com,
	mingo@...e.hu, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, akpm@...ux-foundation.org
Subject: Re: [PATCH] Fix calculus of bitmap_scnprintf_len()

Paul Jackson wrote:
> Bert wrote:
>> The function bitmap_scnprintf_len() is currently not used
> 
> Paul Jackson wrote:
>> How about we just remove that function?
> 
> WANG Cong wrote:
>> I am afraid no. See:
>>
>> include/linux/cpumask.h:292:    return bitmap_scnprintf_len(len);
> 
> Good point.
> 
> 
> Then how about we also remove from cpumask.h:
> 
> #define cpumask_scnprintf_len(len) \
>                         __cpumask_scnprintf_len((len))
> static inline int __cpumask_scnprintf_len(int len)
> {
>         return bitmap_scnprintf_len(len);
> }
> 

That's fine with me.  A later version of the patch did have
the function removed but it didn't get picked up.  The other
changes there were to use function pointers instead of the
flag variable to select list or mask output format, and the
addition of mask variants for the cpu/{present,possible,
online,system} map outputs.

I'll dig that one back up and resubmit it.

Thanks,
Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/