linux-kernel - Re: [patch 26/54] PNP: factor pnp_init_resource_table() and pnp_clean_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200804281115.54997.bjorn.helgaas@hp.com>
Date:	Mon, 28 Apr 2008 11:15:54 -0600
From:	Bjorn Helgaas <bjorn.helgaas@...com>
To:	Rene Herman <rene.herman@...access.nl>
Cc:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Adam Belay <ambx1@....rr.com>,
	Adam M Belay <abelay@....edu>,
	Li Shaohua <shaohua.li@...el.com>,
	Matthieu Castet <castet.matthieu@...e.fr>,
	Thomas Renninger <trenn@...e.de>,
	Jaroslav Kysela <perex@...ex.cz>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 26/54] PNP: factor pnp_init_resource_table() and pnp_clean_resource_table()

On Saturday 26 April 2008 03:33:16 pm Rene Herman wrote:
> On 25-04-08 20:38, Bjorn Helgaas wrote:
> 
> >  void pnp_init_resources(struct pnp_dev *dev)
> >  {
> > -	struct pnp_resource_table *table = &dev->res;
> > +	struct resource *res;
> >  	int idx;
> >  
> >  	for (idx = 0; idx < PNP_MAX_IRQ; idx++) {
> > -		table->irq_resource[idx].name = NULL;
> > -		table->irq_resource[idx].start = -1;
> > -		table->irq_resource[idx].end = -1;
> > -		table->irq_resource[idx].flags =
> > -		    IORESOURCE_IRQ | IORESOURCE_AUTO | IORESOURCE_UNSET;
> > +		res = &dev->res.irq_resource[idx];
> > +		res->flags = IORESOURCE_IRQ;
> 
> ACK as commented earlier but pnp_clean_resource_table would seem to want the 
> same treatment of setting the type, at least to again guarantee current 
> behaviour:

We always initialize the type in pnp_init_resources(), and while we
do fiddle with some of the other bits in the flags element, I can't
see anyplace where we would clear the type.

But I did add code to set the type in pnp_clean_resource_table(),
just in case.  It could be hard to debug a problem there, and it's
harmless to set it again.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/