linux-kernel - Build failure (with insane config)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <adahcdm3b63.fsf@cisco.com>
Date:	Sun, 27 Apr 2008 20:34:12 -0700
From:	Roland Dreier <rdreier@...co.com>
To:	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...e.hu
Subject: Build failure (with insane config)

For x86-64, arch/x86/lib/Makefile has:

        lib-y += csum-partial_64.o csum-copy_64.o csum-wrappers_64.o

so in particular ip_compute_csum() (from csum-partial_64.c) gets put in
libs, so even though it is exported, it gets thrown away at link time if
there are no non-modular users.

However, if someone has an insane config with CONFIG_NET=n and
CONFIG_VIDEO_BT848=m, then ip_compute_csum() gets discarded but the
modular code in drivers/media/video/bt8xx/bttv-cards.c calls it and...

        ERROR: "ip_compute_csum" [drivers/media/video/bt8xx/bttv.ko] undefined!

I guess one fix is just to put at least csum-partial_64.c in obj-y
instead; it does seem broken to have files with EXPORT_SYMBOL() be
lib-y, since it is really an invitation for this problem.  Other ideas
would be for bttv to depend on or select CONFIG_NET.

[It's a long story why I noticed this problem, but maybe we want to fix
it to save people doing randconfig test builds or something like that.
Or maybe we don't really care, since the class of real systems with
video capture cards but no networking is probably quite small]

 - R.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/