linux-kernel - Re: [patch] video: fix SOC_CAMERA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080428193130.GC9907@elte.hu>
Date:	Mon, 28 Apr 2008 21:31:31 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] video: fix SOC_CAMERA_MT9M001 build bug


* Guennadi Liakhovetski <g.liakhovetski@....de> wrote:

> On Mon, 28 Apr 2008, Ingo Molnar wrote:
> 
> > 
> > on latest -git, with this config:
> > 
> >   http://redhat.com/~mingo/misc/config-Mon_Apr_28_13_25_34_CEST_2008.bad
> > 
> >   CONFIG_SOC_CAMERA_MT9M001=y
> >   CONFIG_SOC_CAMERA_MT9V022=y
> >   # CONFIG_I2C is not set
> > 
> > the build fails:
> > 
> > drivers/built-in.o: In function `reg_read':
> > mt9m001.c:(.text+0x140a87): undefined reference to `i2c_smbus_read_word_data'
> > drivers/built-in.o: In function `reg_write':
> > mt9m001.c:(.text+0x140b6e): undefined reference to `i2c_smbus_write_word_data'
> > drivers/built-in.o: In function `reg_read':
> > mt9v022.c:(.text+0x1413a7): undefined reference to `i2c_smbus_read_word_data'
> > drivers/built-in.o: In function `reg_write':
> > mt9v022.c:(.text+0x1414ce): undefined reference to `i2c_smbus_write_word_data'
> > drivers/built-in.o: In function `mt9m001_mod_init':
> > mt9m001.c:(.init.text+0x158a8): undefined reference to `i2c_register_driver'
> > drivers/built-in.o: In function `mt9v022_mod_init':
> > mt9v022.c:(.init.text+0x158b8): undefined reference to `i2c_register_driver'
> > drivers/built-in.o: In function `mt9m001_mod_exit':
> > mt9m001.c:(.exit.text+0x1656): undefined reference to `i2c_del_driver'
> > drivers/built-in.o: In function `mt9v022_mod_exit':
> > mt9v022.c:(.exit.text+0x1666): undefined reference to `i2c_del_driver'
> > 
> > adding the missing I2C dependency fixes it.
> > 
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> 
> NAK. SOC-CAMERA doesn't depend on I2C. It is also suitable for 
> cameras, not using i2c. mt9m001 and mt9v022 do both depend on i2c.

as you can see it from the build log above, the compiler disagrees with 
you on whether the driver depends on I2C. I'm just the messenger :)

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/