| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20080428200958.GF31100@flint.arm.linux.org.uk>
Date: Mon, 28 Apr 2008 21:09:59 +0100
From: Russell King - ARM Linux <linux@....linux.org.uk>
To: Roel Kluin <12o3l@...cali.nl>, Ben Dooks <ben@...tec.co.uk>
Cc: Linux-arm <linux-arm-kernel@...ts.arm.linux.org.uk>,
lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ARM: ax88796: platform_get_irq() may return signed unnoticed
On Wed, Apr 23, 2008 at 11:49:10PM +0200, Roel Kluin wrote:
> similarly,
At the top of the file, it says:
* Copyright 2005,2007 Simtec Electronics
* Ben Dooks <ben@...tec.co.uk>
So adding Ben.
> ---
> dev->irq is unsigned, platform_get_irq() may return signed unnoticed
>
> Signed-off-by: Roel Kluin <12o3l@...cali.nl>
> ---
> diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
> index 194949a..26a735a 100644
> --- a/drivers/net/ax88796.c
> +++ b/drivers/net/ax88796.c
> @@ -838,10 +838,10 @@ static int ax_probe(struct platform_device *pdev)
>
> /* find the platform resources */
>
> - dev->irq = platform_get_irq(pdev, 0);
> - if (dev->irq < 0) {
> + ret = platform_get_irq(pdev, 0);
> + dev->irq = ret;
> + if (ret < 0) {
> dev_err(&pdev->dev, "no IRQ specified\n");
> - ret = -ENXIO;
> goto exit_mem;
> }
>
>
>
> -------------------------------------------------------------------
> List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
> FAQ: http://www.arm.linux.org.uk/mailinglists/faq.php
> Etiquette: http://www.arm.linux.org.uk/mailinglists/etiquette.php
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists