linux-kernel - Re: [patch 41/54] PNP: remove pnp_resource_table references from resource decoders

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4816368A.1070100@keyaccess.nl>
Date:	Mon, 28 Apr 2008 22:41:46 +0200
From:	Rene Herman <rene.herman@...access.nl>
To:	Bjorn Helgaas <bjorn.helgaas@...com>
CC:	Len Brown <lenb@...nel.org>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Adam Belay <ambx1@....rr.com>,
	Adam M Belay <abelay@....edu>,
	Li Shaohua <shaohua.li@...el.com>,
	Matthieu Castet <castet.matthieu@...e.fr>,
	Thomas Renninger <trenn@...e.de>,
	Jaroslav Kysela <perex@...ex.cz>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch 41/54] PNP: remove pnp_resource_table references from
 resource decoders

On 28-04-08 22:36, Bjorn Helgaas wrote:
> On Saturday 26 April 2008 04:28:13 pm Rene Herman wrote:
>> On 25-04-08 20:38, Bjorn Helgaas wrote:
>>
>>> Index: work10/drivers/pnp/pnpacpi/rsparser.c
>>> ===================================================================
>>> --- work10.orig/drivers/pnp/pnpacpi/rsparser.c	2008-04-25 11:15:08.000000000 -0600
>>> +++ work10/drivers/pnp/pnpacpi/rsparser.c	2008-04-25 11:15:09.000000000 -0600
>>> @@ -82,8 +82,8 @@
>>>  						u32 gsi, int triggering,
>>>  						int polarity, int shareable)
>>>  {
>>> -	struct pnp_resource_table *res = dev->res;
>>> -	int i = 0;
>>> +	struct resource *res;
>>> +	int i;
>>>  	int irq;
>>>  	int p, t;
>>>  	static unsigned char warned;
>>> @@ -91,9 +91,11 @@
>>>  	if (!valid_IRQ(gsi))
>>>  		return;
>>>  
>>> -	while (!(res->irq_resource[i].flags & IORESOURCE_UNSET) &&
>>> -	       i < PNP_MAX_IRQ)
>>> -		i++;
>>> +	for (i = 0; i < PNP_MAX_IRQ; i++) {
>>> +		res = &dev->res->irq_resource[i];
>>> +		if (res->flags & IORESOURCE_UNSET)
>>> +			break;
>>> +	}
>> Another possible user of pnp_resource_valid.
> 
> I changed this, and also changed the array lookups to use
> pnp_get_resource().  And I made similar changes in ISAPNP.
> 
> And I replaced many of these &dev->res->irq_resource[] things
> with pnp_get_resource().  This change rippled through several
> subsequent patches, but it's just more mechanical changes.

Great. If you can do the same thing as previously, and leave out / remove my 
Acked-By from the ones that changed so that I can easily identify them, I'll 
  go over the remaining ones (tomorrow, probably).

Rene.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/