linux-kernel - Re: [PATCH v2] eventfd, signalfd, timerfd, epoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <481563E4.5090408@redhat.com>
Date:	Sun, 27 Apr 2008 22:43:00 -0700
From:	Ulrich Drepper <drepper@...hat.com>
To:	Davide Libenzi <davidel@...ilserver.org>
CC:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v2] eventfd, signalfd, timerfd, epoll_create w/flags

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Davide Libenzi wrote:
> unsigned int oflags_remap(const struct oflags_rmap *m, int n,
> 			  int f, int *rf)
> {
> 	int i;
> 	for (i = 0, *rf = 0; i < n; i++, m++)
> 		if (f & m->f) {
> 			*rf |= m->of;
> 			f &= ~m->f;
> 		}
> 	return f ? -EINVAL: 0;
> }

This will be more expensive in terms of code and runtime.  Plus: who
knows whether there will really be other flags which can be used like
this?  I think it's overkill to do this.  If at some point there are
more flags which are handled the same way one could do something like
this but I don't think it's necessary now.

- --
➧ Ulrich Drepper ➧ Red Hat, Inc. ➧ 444 Castro St ➧ Mountain View, CA ❖
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org

iEYEARECAAYFAkgVY+QACgkQ2ijCOnn/RHTN9gCdG6HxUENiLQqmSFPc5LMAcHna
Nc0AnAhma85jwTCS+XTsQ/MrNngQAT+i
=3vVs
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/