linux-kernel - [patch] sched_info_switch not being called according to documentation (10545)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080429090859.GA16568@srcf.ucam.org>
Date:	Tue, 29 Apr 2008 10:08:59 +0100
From:	David Simner <djs203@...f.ucam.org>
To:	linux-kernel@...r.kernel.org
Cc:	mingo@...e.hu
Subject: [patch] sched_info_switch not being called according to
	documentation (10545)

Hi,

http://bugzilla.kernel.org/show_bug.cgi?id=10545

sched_stats.h says that __sched_info_switch is "called when prev !=
next" in the comment.  sched.c should therefore do that, see the patch
below:

David

--- linux-2.6.25-old/kernel/sched.c	2008-04-17 03:49:44.000000000 +0100
+++ linux-2.6.25/kernel/sched.c	2008-04-29 10:54:11.000000000 +0100
@@ -3944,9 +3944,9 @@
 	prev->sched_class->put_prev_task(rq, prev);
 	next = pick_next_task(rq, prev);
 
-	sched_info_switch(prev, next);
-
 	if (likely(prev != next)) {
+		sched_info_switch(prev, next);
+
 		rq->nr_switches++;
 		rq->curr = next;
 		++*switch_count;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/