linux-kernel - Re: [PATCH] toshiba: Use ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080429152312.GB19410@elte.hu>
Date:	Tue, 29 Apr 2008 17:23:12 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>, linux-kernel@...r.kernel.org,
	mingo@...hat.com
Subject: Re: [PATCH] toshiba: Use ioremap_cached

* Andrew Morton <akpm@...ux-foundation.org> wrote:

> > Acked-by: Ingo Molnar <mingo@...e.hu>
> > 
> > i suspect this shouldnt go via x86.git but i've queued it up to 
> > track it.
> 
> Please don't "queue things up to track them".  Just queue them up to 
> merge them, or don't queue them at all.
> 
> Because if you queue it up then I will not.  If you later for some 
> reason unqueue it then volia, it is lost.  We should aim to avoid 
> having multiple copies of a patch sitting around the place.

but ... i dont just unqueue 'for some reason and then volia'. If we did 
that we'd be losing patches left and right. Every patch we unqueue 
happens in a very predictable protocol that should avoid patches getting 
lost.

( basically we only remove any patch when they are broken but even then
  there's a clear notification. Even a NAK or other fatal review 
  feedback does not actually remove a patch in the typical case when the 
  patch otherwise has practical use, and update is hoped for and the 
  patch does not break things - it just freezes the patch at the "must 
  not go upstream yet" end of the queue. )

if we lose any patches then let us know so we can improve the protocol.

> I shall not merge this patch - it is yours.
> 
> > Is there an active maintainer for this file?
> 
> drivers/char/*?  Very rarely maintained.  git-whatchanged tells the 
> story on this one: no.

ok, we'll push it upstream via x86.git after some test period.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/