linux-kernel - Re: Issue with qla2xxx_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080429174447.GL67096@plap4.qlogic.org>
Date:	Tue, 29 Apr 2008 10:44:47 -0700
From:	Andrew Vasquez <andrew.vasquez@...gic.com>
To:	"Alan D. Brunelle" <Alan.Brunelle@...com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Jens Axboe <jens.axboe@...cle.com>, linux-driver@...gic.com,
	linux-scsi@...r.kernel.org
Subject: Re: Issue with qla2xxx_probe_one

On Tue, 29 Apr 2008, Alan D. Brunelle wrote:

> I /think/ that there is an issue with this routine /if/ the firmware
> images are not loaded properly - on a 16-way ia64 box I am starting to
> see this with an up-stream kernel (Jens Axboe's origin/io-cpu-affinity
> branch). In any event, it looks to me that :
> 
>         if (qla2x00_initialize_adapter(ha)) {
>                 qla_printk(KERN_WARNING, ha,
>                     "Failed to initialize adapter\n");
> 
>                 DEBUG2(printk("scsi(%ld): Failed to initialize adapter - "
>                     "Adapter flags %x.\n",
>                     ha->host_no, ha->device_flags));
> 
>                 ret = -ENODEV;
>                 goto probe_failed;
>         }
> 
> skips around:
> 
>         ret = scsi_add_host(host, &pdev->dev);
> 
> which is needed to properly initialize the freelist (via:
> scsi_setup_command_freelist).

Wasn't something like this posted recently to linux-scsi:

http://lkml.org/lkml/2008/4/27/333

this is sitting in scsi-misc-2.6.git:

[SCSI] bug fix for free list handling
http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commitdiff;h=a79cbe1aa5dd695f0ee012ecde1ff88b1192e326

which I gather will be pushed soon...

> When qla2xxx_probe_one ends up calling scsi_host_put in this error path
> it eventually gets to scsi_destroy_command_freelist and we get the error
> below.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/