linux-kernel - Re: [PATCH 1/8] lockdep: fix recursive read lock validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2e108260804291045k353e2ed0r4b14ba4820f6f156@mail.gmail.com>
Date:	Tue, 29 Apr 2008 19:45:43 +0200
From:	"Bart Van Assche" <bart.vanassche@...il.com>
To:	"Peter Zijlstra" <a.p.zijlstra@...llo.nl>
Cc:	ego@...ibm.com, linux-kernel@...r.kernel.org,
	"Zdenek Kabelac" <zdenek.kabelac@...il.com>,
	"Oleg Nesterov" <oleg@...sign.ru>,
	"Heiko Carstens" <heiko.carstens@...ibm.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Ingo Molnar" <mingo@...e.hu>,
	"Srivatsa Vaddagiri" <vatsa@...ibm.com>
Subject: Re: [PATCH 1/8] lockdep: fix recursive read lock validation

On Tue, Apr 29, 2008 at 7:04 PM, Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:
>
>  I think the critical part is:
>
>  > It really is invalid when considered against write locks.
>
>  Aside from that it just states that inversion of lock order will be
>  treated as invalid - even for read locks.

Inversion of recursive reader locks can't trigger a deadlock, even
when considered against write locks, as long as the rules are followed
I posted earlier. I invite anyone to come up with an example that
proves me wrong.

Let's return to the starting point of this discussion. The patch at
the start of this thread forbids to invert the lock order of reader
locks. Why to forbid this if it can't trigger a deadlock ? At least in
user space code, it's quite easy to trigger such inversion. In
sufficiently complex code where functions call other functions while
holding a reader lock, reader lock inversion can be hard to avoid.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/