linux-kernel - Re: [2.6 patch] iwlwifi: move the selects to the tristate drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 28 Apr 2008 19:45:48 -0400
From:	"John W. Linville" <linville@...driver.com>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	David Miller <davem@...emloft.net>, linux-kernel@...r.kernel.org,
	reinette.chatre@...el.com, torvalds@...ux-foundation.org,
	yi.zhu@...el.com, linux-wireless@...r.kernel.org
Subject: Re: [2.6 patch] iwlwifi: move the selects to the tristate drivers

On Mon, Apr 28, 2008 at 11:58:49PM +0300, Adrian Bunk wrote:

> This patch moves the following select's:
> - RFKILL        : IWLWIFI_RFKILL -> IWLCORE
> - RFKILL_INPUT  : IWLWIFI_RFKILL -> IWLCORE
> - MAC80211_LEDS : IWL4965_LEDS   -> IWLCORE
> - LEDS_CLASS    : IWL4965_LEDS   -> IWLCORE
> - MAC80211_LEDS : IWL3945_LEDS   -> IWL3945
> - LEDS_CLASS    : IWL3945_LEDS   -> IWL3945
> 
> The effects are:
> - with IWLCORE=m and/or IWL3945=m RFKILL/RFKILL_INPUT/MAC80211_LEDS/LEDS_CLASS
>   are no longer wrongly forced to y
> - fixes a build error with IWLCORE=y, IWL4965=m
>   might be a bug in kconfig causing it, but doing this change that is 
>   anyway the right thing fixes it
> 
> Reported-by: Carlos R. Mafra <crmafra2@...il.com>
> Signed-off-by: Adrian Bunk <bunk@...nel.org>

This seems sane to me -- I'm sorry I let so much Kconfig mess slip
through on this driver in the first place!

> ---
> 
> BTW: There's no correlation between IWL3945_LEDS and IWLWIFI_LEDS.
>      That seems to be intended?

Yes.  IWLWIFI_LEDS used to be IWL4965_LEDS, and I have the impression
that eventually it will subsume IWL3945_LEDS as well.

Dave, are you going to snarf this one too?  If not (and presuming no
one points out yet another problem) I'll just include it in the next
round of fix patches, probably on tomorrow.

John
-- 
John W. Linville
linville@...driver.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/