| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <86802c440804291449y50f178a6x4e200c26840493a@mail.gmail.com> Date: Tue, 29 Apr 2008 14:49:22 -0700 From: "Yinghai Lu" <yhlu.kernel@...il.com> To: "Gabriel C" <nix.or.die@...glemail.com> Cc: "Andrew Morton" <akpm@...ux-foundation.org>, "Ingo Molnar" <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>, "Thomas Gleixner" <tglx@...utronix.de>, "Mika Fischer" <mika.fischer@...pnet.de>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 1/2] x86: mtrr cleanup for converting continuous to discrete layout v7 On Tue, Apr 29, 2008 at 1:25 PM, Gabriel C <nix.or.die@...glemail.com> wrote: > > Yinghai Lu wrote: > > On Tue, Apr 29, 2008 at 4:51 AM, Gabriel C <nix.or.die@...glemail.com> wrote: > >> Yinghai Lu wrote: > >> > On Tue, Apr 29, 2008 at 3:30 AM, Yinghai Lu <yhlu.kernel@...il.com> wrote: > >> >> On Tue, Apr 29, 2008 at 2:47 AM, Gabriel C <nix.or.die@...glemail.com> wrote: > >> >> > Yinghai Lu wrote: > >> >> > > some BIOS like to use continus MTRR layout, and may X driver can not add > >> >> > > WB entries for graphical cards when 4g or more RAM installed. > >> >> > > > >> >> > > the patch will change MTRR to discrete. > >> >> > > > >> >> > > mtrr_chunk_size= could be used to have smaller continuous block to hold holes. > >> >> > > default is 256m, could be set according to size of graphics card memory. > >> >> > > > >> >> > > v2: fix -1 for UC checking > >> >> > > v3: default to disable, and need use enable_mtrr_cleanup to enable this feature > >> >> > > skip the var state change warning. > >> >> > > remove next_basek in range_to_mtrr() > >> >> > > v4: correct warning mask. > >> >> > > v5: CONFIG_MTRR_SANITIZER > >> >> > > v6: fix 1g, 2g, 512 aligment with extra hole > >> >> > > v7: gran_sizek to prevent running out of MTRRs. > >> >> > > > >> >> > > >> >> > With this version ( and patch http://lkml.org/lkml/2008/4/29/97 ) applyed on latest linus git tree > >> >> > the box OOPS'es early. > >> >> > > >> >> > Sorry I don't have time right now to write down the part of the OOPS I can see on monitor , I can try to find > >> >> > some time later. > >> >> > > >> >> > In any way OOPS'es on __free_one_page+0x191/0x21e > >> >> > >> >> thanks. found one problem with hole_basek ... > >> >> > >> >> will send you v8, and hope it will be last version. > >> > > >> > please try v8, it should get rid of the 8m entry. it need patch > >> > http://lkml.org/lkml/2008/4/29/97 too. > >> > >> Box does boot with v8 but now I get that warning you fixed in v2 again =): > >> > >> .... > >> [ 0.000000] Linux version 2.6.25-06058-ga01e035-dirty (crazy@...r) (gcc version 4.3.0 (Frugalware Linux) ) #805 SMP PREEMPT Tue Apr 29 13:04:49 CEST 2008 > >> [ 0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317 > >> [ 0.000000] BIOS-provided physical RAM map: > >> [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable) > >> [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved) > >> [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved) > >> [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable) > >> [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data) > >> [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > >> [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved) > >> [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved) > >> [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved) > >> [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable) > >> [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used > >> [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used > >> [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used > >> [ 0.000000] max_pfn_mapped = 1228800 > >> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106 > >> [ 0.000000] After WB checking > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000 > >> [ 0.000000] After UC checking > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> [ 0.000000] After sorting > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> [ 0.000000] range0: 0000000000000000 - 00000000c0000000 > >> [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB > >> [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB > >> [ 0.000000] range: 00000000c0000000 - 00000000d0000000 > >> [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 256MB, type WB > >> [ 0.000000] hole: 00000000cc000000 - 00000000d0000000 > >> [ 0.000000] Setting variable MTRR 3, base: 3264MB, range: 64MB, type UC > >> [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000 > >> [ 0.000000] range0: 0000000100000000 - 0000000120000000 > >> [ 0.000000] Setting variable MTRR 4, base: 4096MB, range: 512MB, type WB > >> [ 0.000000] range: 0000000120000000 - 0000000130000000 > >> [ 0.000000] Setting variable MTRR 5, base: 4608MB, range: 256MB, type WB > >> [ 0.000000] hole: 000000012c000000 - 0000000130000000 > >> [ 0.000000] Setting variable MTRR 6, base: 4800MB, range: 64MB, type UC > >> [ 0.000000] DONE variable MTRRs > >> [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106 > >> [ 0.000000] After WB checking > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000d0000 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000130000 > >> [ 0.000000] After UC checking > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> [ 0.000000] After sorting > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > >> [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM. > > > > so > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > >> [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > > ===> > >> [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cc000 > >> [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > > > > please try > > Now I have 2 warnings > > > > mtrr_chunk_size=512m mtrr_gran_size=128m > > ... > > [ 0.000000] Command line: root=/dev/sdb1 ro debug vga=0x317 mtrr_chunk_size=512m mtrr_gran_size=128m 3 > > > [ 0.000000] BIOS-provided physical RAM map: > [ 0.000000] BIOS-e820: 0000000000000000 - 000000000009cc00 (usable) > [ 0.000000] BIOS-e820: 000000000009cc00 - 00000000000a0000 (reserved) > [ 0.000000] BIOS-e820: 00000000000e4000 - 0000000000100000 (reserved) > [ 0.000000] BIOS-e820: 0000000000100000 - 00000000cf550000 (usable) > [ 0.000000] BIOS-e820: 00000000cf550000 - 00000000cf55e000 (ACPI data) > [ 0.000000] BIOS-e820: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > [ 0.000000] BIOS-e820: 00000000cf5e0000 - 00000000cf600000 (reserved) > [ 0.000000] BIOS-e820: 00000000fee00000 - 00000000fee01000 (reserved) > [ 0.000000] BIOS-e820: 00000000ffc00000 - 0000000100000000 (reserved) > [ 0.000000] BIOS-e820: 0000000100000000 - 000000012c000000 (usable) > [ 0.000000] Entering add_active_range(0, 0, 156) 0 entries of 256 used > [ 0.000000] Entering add_active_range(0, 256, 849232) 1 entries of 256 used > [ 0.000000] Entering add_active_range(0, 1048576, 1228800) 2 entries of 256 used > [ 0.000000] max_pfn_mapped = 1228800 > [ 0.000000] x86 PAT enabled: cpu 0, old 0x7040600070406, new 0x7010600070106 > [ 0.000000] After WB checking > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 000000000012c000 > [ 0.000000] After UC checking > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > [ 0.000000] After sorting > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000cf600 > [ 0.000000] MTRR MAP PFN: 00000000000cf800 - 00000000000d0000 > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 000000000012c000 > [ 0.000000] range0: 0000000000000000 - 00000000c0000000 > [ 0.000000] Setting variable MTRR 0, base: 0MB, range: 2048MB, type WB > [ 0.000000] Setting variable MTRR 1, base: 2048MB, range: 1024MB, type WB > [ 0.000000] range: 00000000c0000000 - 00000000c8000000 > [ 0.000000] Setting variable MTRR 2, base: 3072MB, range: 128MB, type WB > > [ 0.000000] rangeX: 00000000d0000000 - 00000000d0000000 > [ 0.000000] range0: 0000000100000000 - 0000000120000000 > [ 0.000000] Setting variable MTRR 3, base: 4096MB, range: 512MB, type WB > [ 0.000000] range: 0000000120000000 - 0000000128000000 > [ 0.000000] Setting variable MTRR 4, base: 4608MB, range: 128MB, type WB > > [ 0.000000] DONE variable MTRRs > [ 0.000000] x86 PAT enabled: cpu 0, old 0x7010600070106, new 0x7010600070106 > [ 0.000000] After WB checking > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > > [ 0.000000] After UC checking > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > [ 0.000000] After sorting > [ 0.000000] MTRR MAP PFN: 0000000000000000 - 00000000000c8000 > [ 0.000000] MTRR MAP PFN: 0000000000100000 - 0000000000128000 > [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 64MB of RAM. > [ 0.000000] ------------[ cut here ]------------ > [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1206 mtrr_trim_uncached_memory+0x25b/0x35a() > > [ 0.000000] Modules linked in: > [ 0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06058-ga01e035-dirty #805 > [ 0.000000] > [ 0.000000] Call Trace: > [ 0.000000] [<ffffffff8022d661>] warn_on_slowpath+0x51/0x78 > [ 0.000000] [<ffffffff8067f0dc>] x86_get_mtrr_mem_range+0x241/0x25c > [ 0.000000] [<ffffffff8067d93e>] update_memory_range+0x95/0xb7 > [ 0.000000] [<ffffffff8067fa51>] mtrr_trim_uncached_memory+0x25b/0x35a > > [ 0.000000] [<ffffffff8067ca43>] setup_arch+0x280/0x4a2 > [ 0.000000] [<ffffffff80676aa6>] start_kernel+0x6e/0x308 > [ 0.000000] [<ffffffff80676432>] x86_64_start_kernel+0x241/0x24a > [ 0.000000] > [ 0.000000] ---[ end trace ca143223eefdc828 ]--- > [ 0.000000] update e820 for mtrr -- end_pfn > [ 0.000000] modified physical RAM map: > [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable) > [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved) > [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved) > [ 0.000000] modified: 0000000000100000 - 00000000cf550000 (usable) > [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data) > [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved) > [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved) > [ 0.000000] modified: 00000000ffc00000 - 0000000100000000 (reserved) > [ 0.000000] modified: 0000000100000000 - 0000000128000000 (usable) > [ 0.000000] modified: 0000000128000000 - 000000012c000000 (reserved) > > [ 0.000000] WARNING: BIOS bug: CPU MTRRs don't cover all of memory, losing 757MB of RAM. > > [ 0.000000] ------------[ cut here ]------------ > [ 0.000000] WARNING: at arch/x86/kernel/cpu/mtrr/main.c:1227 mtrr_trim_uncached_memory+0x30c/0x35a() > [ 0.000000] Modules linked in: > [ 0.000000] Pid: 0, comm: swapper Not tainted 2.6.25-06058-ga01e035-dirty #805 > [ 0.000000] > [ 0.000000] Call Trace: > [ 0.000000] [<ffffffff8022d661>] warn_on_slowpath+0x51/0x78 > [ 0.000000] [<ffffffff8067f0dc>] x86_get_mtrr_mem_range+0x241/0x25c > [ 0.000000] [<ffffffff8067d93e>] update_memory_range+0x95/0xb7 > [ 0.000000] [<ffffffff8067fb02>] mtrr_trim_uncached_memory+0x30c/0x35a > [ 0.000000] [<ffffffff8067ca43>] setup_arch+0x280/0x4a2 > [ 0.000000] [<ffffffff80676aa6>] start_kernel+0x6e/0x308 > [ 0.000000] [<ffffffff80676432>] x86_64_start_kernel+0x241/0x24a > [ 0.000000] > [ 0.000000] ---[ end trace ca143223eefdc828 ]--- > [ 0.000000] update e820 for mtrr -- holes > [ 0.000000] modified physical RAM map: > [ 0.000000] modified: 0000000000000000 - 000000000009cc00 (usable) > [ 0.000000] modified: 000000000009cc00 - 00000000000a0000 (reserved) > [ 0.000000] modified: 00000000000e4000 - 0000000000100000 (reserved) > [ 0.000000] modified: 0000000000100000 - 00000000c8000000 (usable) > [ 0.000000] modified: 00000000c8000000 - 00000000cf550000 (reserved) > [ 0.000000] modified: 00000000cf550000 - 00000000cf55e000 (ACPI data) > [ 0.000000] modified: 00000000cf55e000 - 00000000cf5e0000 (ACPI NVS) > [ 0.000000] modified: 00000000cf5e0000 - 00000000cf600000 (reserved) > [ 0.000000] modified: 00000000fee00000 - 00000000fee01000 (reserved) > [ 0.000000] modified: 00000000ffc00000 - 000000012c000000 (reserved) > > [ 0.000000] Entering add_active_range(0, 0, 156) 3 entries of 256 used > [ 0.000000] Entering add_active_range(0, 256, 819200) 3 entries of 256 used please try attached trim_holes_fix.patch..., it will fix the trim hole problem. then check if X server works well. then try mtrr_cleanup_fix.patch for... ==> address ingo request about style etc. Thanks Yinghai Lu View attachment "trim_holes_fix.patch" of type "text/x-patch" (573 bytes) View attachment "mtrr_cleanup_fix.patch" of type "text/x-patch" (10197 bytes)
Powered by blists - more mailing lists