linux-kernel - Re: [PATCH] x86: restrict keyboard io ports reservation to make ipmi driver work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0804300055010.6003@apollo.tec.linutronix.de>
Date:	Wed, 30 Apr 2008 00:55:29 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Yinghai Lu <yhlu.kernel@...il.com>
cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Helge Wagner <Helge.Wagner@...anuc.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] x86: restrict keyboard io ports reservation to make ipmi
 driver work



On Tue, 29 Apr 2008, Yinghai Lu wrote:

> On Tue, Apr 29, 2008 at 2:46 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> > From: Helge Wagner <Helge.Wagner@...anuc.com>
> >
> >  On some of our (single board computer) boards (x86) we are using an
> >  IPMI controller that uses I/O ports 0x62 and 0x66 for a KCS (keyboard
> >  controller style) IPMI system interface.
> >
> >  Trying to load the openipmi driver fails, because the ports
> >  (0x62/0x66) are reserved for keyboard. keyboard reserves the full
> >  range 0x60-0x6F while it doesn't need to.
> >
> >  Reserve only ports 0x60 and 0x64 for the legacy PS/2 i8042 keyboad
> >  controller instead of 0x60-0x6F to allow the openipmi driver to work.
> >
> >  Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> >  ---
> >   arch/x86/kernel/setup_32.c |    7 ++++++-
> >   1 file changed, 6 insertions(+), 1 deletion(-)
> >
> >  Index: linux-2.6/arch/x86/kernel/setup_32.c
> >  ===================================================================
> >  --- linux-2.6.orig/arch/x86/kernel/setup_32.c
> >  +++ linux-2.6/arch/x86/kernel/setup_32.c
> >  @@ -127,7 +127,12 @@ static struct resource standard_io_resou
> >   }, {
> >         .name   = "keyboard",
> >         .start  = 0x0060,
> >  -       .end    = 0x006f,
> >  +       .end    = 0x0060,
> >  +       .flags  = IORESOURCE_BUSY | IORESOURCE_IO
> >  +}, {
> >  +       .name   = "keyboard",
> >  +       .start  = 0x0064,
> >  +       .end    = 0x0064,
> >         .flags  = IORESOURCE_BUSY | IORESOURCE_IO
> >   }, {
> >         .name   = "dma page reg",
> >  --
> 
> 64 bit need to be fixed too...
>         { .name = "keyboard", .start = 0x60, .end = 0x6f,
>                 .flags = IORESOURCE_BUSY | IORESOURCE_IO },

Doh, yes.

Thanks,
	tglx
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/