linux-kernel - Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <37219a840804291649q36638464ye2d57cf8184580a4@mail.gmail.com>
Date:	Tue, 29 Apr 2008 19:49:24 -0400
From:	"Michael Krufky" <mkrufky@...uxtv.org>
To:	"Mauro Carvalho Chehab" <mchehab@...radead.org>
Cc:	"Linus Torvalds" <torvalds@...ux-foundation.org>,
	linux-dvb-maintainer@...uxtv.org,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	video4linux-list@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [v4l-dvb-maintainer] [GIT PATCHES] V4L/DVB updates and fixes for 2.6.26

On Tue, Apr 29, 2008 at 5:50 PM, Mauro Carvalho Chehab
<mchehab@...radead.org> wrote:
> Linus,
>
>  Please pull from:
>         ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/v4l-dvb.git master
>
>  For the following:
>
>    - Fixes on mtm001, mtv022, pvrusb2, ivtv, cx88 and saa7134;
>    - new board additions on saa7134 and ivtv;
>    - load tuners only when needed;
>    - reorganization of tuner drivers that are shared between DVB and V4L;
>    - Addition of a new driver for Conexant CX23418 MPEG encoder chip (cx18).

[snip]

>  Mauro Carvalho Chehab (9):
>       Rename common tuner Kconfig names to use the same
>
>  Michael Krufky (4):
>       V4L/DVB (7789): tuner: remove static dependencies on analog tuner sub-modules


Linus has already merged the changes (thank you, Linus) ... However,
there is a bug.

My "remove static dependencies on analog tuner sub-modules" patch was
applied after Mauro's "Rename common tuner Kconfig names to use the
same" patch.

My patch has conditional behavior, based on CONFIG_DVB_CORE_ATTACH,
which was renamed to CONFIG_MEDIA_ATTACH in Mauro's patch.

To fix this, we need to do:

sed -i s/"CONFIG_DVB_CORE_ATTACH"/"CONFIG_MEDIA_ATTACH"/1
drivers/media/video/tuner-core.c

The issue will cause invalid module use counts upon unloading analog
tuner modules, if CONFIG_MEDIA_ATTACH is enabled.

I would be happy to fix this myself, but Mauro's patch has not yet
been backported into the linuxtv.org repository.

Mauro, can you do the above fix and send it in to Linus?

Thanks,

Mike Krufky
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/