linux-kernel - Re: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hk5ifwrnz.wl%tiwai@suse.de>
Date:	Wed, 30 Apr 2008 12:41:52 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...radead.org>
Subject: Re: [patch] sound/video: fix sound/i2c/other/tea575x-tuner.c build bug

At Tue, 29 Apr 2008 22:46:43 +0200,
Ingo Molnar wrote:
> 
> 
> fix build failure triggered on latest -git by this config:
> 
>  http://redhat.com/~mingo/misc/config-Tue_Apr_29_22_33_36_CEST_2008.bad
> 
> sound/i2c/other/tea575x-tuner.c: In function 'snd_tea575x_ioctl':
> sound/i2c/other/tea575x-tuner.c:95: error: 'VIDIOCGCAP' undeclared (first use in this function)
> sound/i2c/other/tea575x-tuner.c:95: error: (Each undeclared identifier is reported only once
> sound/i2c/other/tea575x-tuner.c:95: error: for each function it appears in.)
> sound/i2c/other/tea575x-tuner.c:97: error: storage size of 'v' isn't known
> 
> the CONFIG_SND_FM801_TEA575X code still depends on VIDEO_V4L1_COMPAT 
> APIs.

I'm afraid that the select of VIDEO_V4L1 from fm801 makes the things
messy enough.  And more select, eh...  IMO, this should be rather
depend on VIDEO_V4L1.

But, there is a dependency chain problem among snd-fm801,
snd-fm801-tea575x and V4L layer.  I'll check it.


Takashi

> 
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  sound/pci/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux/sound/pci/Kconfig
> ===================================================================
> --- linux.orig/sound/pci/Kconfig
> +++ linux/sound/pci/Kconfig
> @@ -529,6 +529,7 @@ config SND_FM801_TEA575X
>  	depends on SND_FM801_TEA575X_BOOL
>  	default SND_FM801
>  	select VIDEO_V4L1
> +	select VIDEO_V4L1_COMPAT
>  	select VIDEO_DEV
>  
>  config SND_HDA_INTEL
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/