linux-kernel - Re: [patch, -git] media/video/sound build fix, TEA5761/TEA5767

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hd4o7wo00.wl%tiwai@suse.de>
Date:	Wed, 30 Apr 2008 14:01:03 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-dvb-maintainer@...uxtv.org, video4linux-list@...hat.com,
	linux-kernel@...r.kernel.org, Mike Galbraith <efault@....de>
Subject: Re: [patch, -git] media/video/sound build fix, TEA5761/TEA5767

At Wed, 30 Apr 2008 13:18:03 +0200,
Ingo Molnar wrote:
> 
> 
> * Ingo Molnar <mingo@...e.hu> wrote:
> 
> > > IMO, it's the reverse selection from sound to V4L that makes things 
> > > complicated.  I believe it's better to fix it as a normal 
> > > dependency.
> > > 
> > > How about the patch below?
> > 
> > thanks, i've added it to the mix, instead of my patch.
> 
> it now fails with another randconfig:
> 
>    http://redhat.com/~mingo/misc/config-Wed_Apr_30_13_13_26_CEST_2008.bad

What error did you get with this?

> i've added back my hack to keep things rolling. (Note: i've got some 
> media drivers hacks in this tree too so maybe one of them has a 
> side-effect)

Taking a quick look,

	CONFIG_VIDEO_DEV=y
	CONFIG_VIDEO_V4L2_COMMON=y
	# CONFIG_VIDEO_ALLOW_V4L1 is not set
	CONFIG_VIDEO_V4L1_COMPAT=y

seems strange.  VIDEO_ALLOW_V4L1 should have been selected since
drivers/media/video/Kconfig contains the following:

	config VIDEO_V4L1
		tristate
		depends on VIDEO_DEV && VIDEO_V4L2_COMMON && VIDEO_ALLOW_V4L1
		default VIDEO_DEV && VIDEO_V4L2_COMMON && VIDEO_ALLOW_V4L1

I guess the remaining reverse-selection caused this.


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/