linux-kernel - Re: [PATCH 1/2] mm: Avoid putting a bad page back on the LRU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080429071715.5d39d9c1@infradead.org>
Date:	Tue, 29 Apr 2008 07:17:15 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Russ Anderson <rja@....com>, linux-kernel@...r.kernel.org,
	linux-ia64@...r.kernel.org, torvalds@...ux-foundation.org,
	tony.luck@...el.com, clameter@....com
Subject: Re: [PATCH 1/2] mm: Avoid putting a bad page back on the LRU

On Tue, 29 Apr 2008 14:33:29 -0700
Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Mon, 28 Apr 2008 14:23:58 -0500
> Russ Anderson <rja@....com> wrote:
> 
> > --- test.orig/include/linux/kernel.h	2008-04-25
> > 15:22:07.640501421 -0500 +++ test/include/linux/kernel.h
> > 2008-04-25 15:42:02.826266036 -0500 @@ -412,6 +412,7 @@ struct
> > sysinfo { unsigned long totalhigh;	/* Total high memory size
> > */ unsigned long freehigh;		/* Available high memory
> > size */ unsigned int mem_unit;		/* Memory unit size
> > in bytes */
> > +	unsigned int badpages;		/* Number of bad
> > (PG_memerror) pages */ char
> > _f[20-2*sizeof(long)-sizeof(int)];	/* Padding: libc5 uses
> > this.. */ };
> 
> eek.  sys_sysinfo() copies this structure out to userspace verbatim. 
> Increasing its size by four bytes will cause memory scribbles in
> userspace applications.

not if you also reduce the padding ??


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/