linux-kernel - Re: [2.6 patch] iwlwifi: move the selects to the tristate drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080430133143.GA4679@beyonder.ift.unesp.br>
Date:	Wed, 30 Apr 2008 10:31:43 -0300
From:	"Carlos R. Mafra" <crmafra2@...il.com>
To:	bunk@...nel.org
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] iwlwifi: move the selects to the tristate drivers

On Tue 29.Apr'08 at 22:30:54 -0700, David Miller wrote:
> From: Adrian Bunk <bunk@...nel.org>
> Date: Mon, 28 Apr 2008 23:58:49 +0300
> 
> > This patch moves the following select's:
> > - RFKILL        : IWLWIFI_RFKILL -> IWLCORE
> > - RFKILL_INPUT  : IWLWIFI_RFKILL -> IWLCORE
> > - MAC80211_LEDS : IWL4965_LEDS   -> IWLCORE
> > - LEDS_CLASS    : IWL4965_LEDS   -> IWLCORE
> > - MAC80211_LEDS : IWL3945_LEDS   -> IWL3945
> > - LEDS_CLASS    : IWL3945_LEDS   -> IWL3945
> > 
> > The effects are:
> > - with IWLCORE=m and/or IWL3945=m RFKILL/RFKILL_INPUT/MAC80211_LEDS/LEDS_CLASS
> >   are no longer wrongly forced to y
> > - fixes a build error with IWLCORE=y, IWL4965=m
> >   might be a bug in kconfig causing it, but doing this change that is 
> >   anyway the right thing fixes it
> > 
> > Reported-by: Carlos R. Mafra <crmafra2@...il.com>
> > Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> Applied, thanks a lot Adrian.

Yeah Adrian, thank you very much!

It is really useful for the kernel to have someone like you cleaning 
up these Kconfig mistakes. My dumb patch was not good and now at 
least I know how it should be done.
Keep up your great work!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/