linux-kernel - Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build fix for modular builds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080430082959.5982ef70.akpm@linux-foundation.org>
Date:	Wed, 30 Apr 2008 08:29:59 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	"Michael Krufky" <mkrufky@...uxtv.org>
Cc:	"Mike Galbraith" <efault@....de>, sfr@...b.auug.org.au,
	video4linux-list@...hat.com, "Sam Ravnborg" <sam@...nborg.org>,
	linux-kernel@...r.kernel.org, mchehab@...radead.org,
	linux-dvb-maintainer@...uxtv.org, "Ingo Molnar" <mingo@...e.hu>,
	torvalds@...ux-foundation.org, "David Miller" <davem@...emloft.net>
Subject: Re: [v4l-dvb-maintainer] [patch, -git] drivers/media build fix for
 modular builds

On Wed, 30 Apr 2008 10:39:31 -0400 "Michael Krufky" <mkrufky@...uxtv.org> wrote:

> >  [   13.691175] DVB: Unable to find symbol tda9887_attach()
> >  [   13.698968] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
> >  [   13.709509] IP: [<ffffffff80302934>] strlcpy+0x11/0x36

hm.

> 
> Andrew's patch should have fixed the issue.  His patch was correct, btw...

They always are ;)  Watch this....

--- a/drivers/media/video/tuner-core.c~drivers-media-video-tuner-corec-tuner_probe-fix-error-check
+++ a/drivers/media/video/tuner-core.c
@@ -1181,7 +1181,7 @@ static int tuner_probe(struct i2c_client
 		case 0x60:
 			if (tuner_symbol_probe(tea5767_autodetection,
 					       t->i2c->adapter, t->i2c->addr)
-					!= EINVAL) {
+					!= -EINVAL) {
 				t->type = TUNER_TEA5767;
 				t->mode_mask = T_RADIO;
 				t->mode = T_STANDBY;
_

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/