linux-kernel - Re: [patch] inlining: do not allow gcc below version 4 to optimize inlining

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Apr 2008 21:58:10 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [patch] inlining: do not allow gcc below version 4 to optimize inlining

On Wed, Apr 30, 2008 at 10:03:07PM +0300, Adrian Bunk wrote:
> >  /*
> > - * Force always-inline if the user requests it so via the .config:
> > + * Force always-inline if the user requests it so via the .config,
> > + * or if gcc is too old:
> >   */
> >  #if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \
> > -    !defined(CONFIG_OPTIMIZE_INLINING) && (__GNUC__ >= 4)
> 
> One moment.
> 
> Let me try to understand what we currently have in the tree.
> 
> This *always* enables the so called "optimized inlining" for the older 
> compilers we did *not* wanted to have this for.
> 
> Even with CONFIG_OPTIMIZE_INLINING=n .
> 
> How was this reviewed and tested?

I for one reviewed this.
No I did not catch the obvious bug and
feel free to flame me for that.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/