linux-kernel - Re: [patch, -git] input: CONFIG_INPUT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 30 Apr 2008 18:21:04 -0400
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Roman Zippel <zippel@...ux-m68k.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Stephen Hemminger <shemminger@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [patch, -git] input: CONFIG_INPUT_APANEL build fix

On Wed, Apr 30, 2008 at 10:56:05PM +0200, Roman Zippel wrote:
> Hi,
> 
> On Wed, 30 Apr 2008, Ingo Molnar wrote:
> 
> > > Thank you Ingo. Isn't this a Kconfig issue though? I know that Roman 
> > > is not willing to fix SELECT to evaluate the whole dependency chain, 
> > > but in this case it is "depens on" that does not evaluate properly...
> > 
> > yes and no. It can be fixed in Kconfig but i'm not going to flame yet 
> > another person about long-existing unfixed infrastructure bugs ;-)
> 
> You don't have to, because this simply is no infrastructure bug...
> Don't blame Kconfig for abusing select for something it was never 
> intendend for. There is no bug!
>

That is all fine and dandy except that apanel does not select LEDs, it
depends on LEDS_CLASS.
 
> In this case there is now a mixture of depends and selects on leds. First 
> decide whether led support should be automatically included or the driver 
> is only available when led support is enabled. In the first case it's 
> probably better to create LEDS_SUPPORT, which then again selects 
> everything necessary.
>

The decision is made, the driver depends on LEDs except that it is not
working.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/