linux-kernel - Re: false negative in checpatch for asm/ vs. linux/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080501102431.GC20317@shadowen.org>
Date:	Thu, 1 May 2008 11:24:31 +0100
From:	Andy Whitcroft <apw@...dowen.org>
To:	Nishanth Aravamudan <nacc@...ibm.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: false negative in checpatch for asm/ vs. linux/

On Tue, Apr 29, 2008 at 09:49:18AM -0700, Nishanth Aravamudan wrote:
> Hi Andy,
> 
> I think the following:
> 
> #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
>                 if ($tree && $rawline =~ m{^.\#\s*include\s*\<asm\/(.*)\.h\>}) {
>                         my $checkfile = "$root/include/linux/$1.h";
>                         if (-f $checkfile && $1 ne 'irq') {
>                                 WARN("Use #include <linux/$1.h> instead of <asm/$1.h>\n" .
>                                         $herecurr);
>                         }
>                 }
> 
> in checkpatch.pl can lead to false positives for asm/ includes from within
> linux/ files? e.g., I have a patch which moves the asm/hugetlb.h #include up to
> the top of include/linux/hugetlb.h, but I get:
> 
> [09:46:27]nacc@...anoid:~/linux/views/linux-2.6-work$ git show HEAD | ./scripts/checkpatch.pl -
> WARNING: Use #include <linux/hugetlb.h> instead of <asm/hugetlb.h>
> #17: FILE: include/linux/hugetlb.h:8:
> +#include <asm/hugetlb.h>

Yes, clearly stupid and trivial to detect.  Will be sorted in the 0.19.

Thanks for the report.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/