linux-kernel - Re: [OP] v2.6.22.22-op1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49fxt2axns.fsf@segfault.boston.devel.redhat.com>
Date:	Thu, 01 May 2008 10:47:51 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	oliver.pntr@...il.com
Cc:	linux-kernel@...r.kernel.org, Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Badari Pulavarty <pbadari@...ibm.com>,
	Benjamin LaHaise <bcrl@...ck.org>,
	Chris Wright <chrisw@...s-sol.org>,
	Davide Libenzi <davidel@...ilserver.org>,
	"David S. Miller" <davem@...emloft.net>,
	Grant Grundler <grundler@...isc-linux.org>,
	Hugh Dickins <hugh@...itas.com>,
	James Morris <jmorris@...ei.org>, Jan Kara <jack@....cz>,
	Jeff Garzik <jeff@...zik.org>,
	Jeff Roberson <jroberson@...sapeake.net>,
	Jens Axboe <jens.axboe@...cle.com>,
	Johann Felix Soden <johfel@...rs.sourceforge.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Nick Piggin <npiggin@...e.de>,
	Patrick McHardy <kaber@...sh.net>,
	Robert Love <rlove@...gle.com>,
	Stephen Smalley <sds@...ho.nsa.gov>,
	Suparna Bhattacharya <suparna@...ibm.com>,
	Willy Tarreau <w@....eu>, Yan Zheng <yanzheng@...n.com>,
	Zach Brown <zach.brown@...cle.com>
Subject: Re: [OP] v2.6.22.22-op1

<oliver@...ernowsky.hu> writes:

> I announced the v2.6.22.22-op1 "stable" kernel.

>  fs/aio.c                    |   23 ++++++++++++-----------

> Jeff Moyer (1):
>       aio: account I/O wait time properly

This version of the patch introduced a regression for UML.  It was
seeing 100% iowait time when it wasn't waiting on any I/O.  There was a
follow-up patch which did the io_schedule conditionally, see commit id:

  e00ba3dae077f54cfd2af42e939a618caa7a3bca

Cheers,

Jeff

> diff --git a/fs/aio.c b/fs/aio.c
> index dbe699e..b3419c5 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -1170,7 +1171,7 @@ retry:
>  			ret = 0;
>  			if (to.timed_out)	/* Only check after read evt */
>  				break;
> -			schedule();
> +			io_schedule();
>  			if (signal_pending(tsk)) {
>  				ret = -EINTR;
>  				break;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/