linux-kernel - Re: [PATCH] Fix SMP alternatives : use mutex instead of spinlock, text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.10.0805011151521.5994@woody.linux-foundation.org>
Date:	Thu, 1 May 2008 11:52:53 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>
cc:	Ingo Molnar <mingo@...e.hu>, Luca Tettamanti <kronos.it@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix SMP alternatives : use mutex instead of spinlock,
 text_poke is sleepable



On Thu, 1 May 2008, Mathieu Desnoyers wrote:
> 
> Yep. I think using a mutex should fix it. There is no reason to use a
> spinlock rather than a mutex here.

Is there any reason to do any locking what-so-ever?

If this code could possibly race with something else, that sounds like a 
bug in itself, no?

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/