linux-kernel - Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 1 May 2008 22:31:07 +0300
From:	Adrian Bunk <bunk@...nel.org>
To:	Andres Freund <andres@...razel.de>
Cc:	linux-kernel@...r.kernel.org, apdim@...cian.net,
	Mauro Carvalho Chehab <mchehab@...radead.org>
Subject: Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION
	macro is used.

On Thu, May 01, 2008 at 08:05:41PM +0200, Andres Freund wrote:
> Whitout this build fails with unknown macro on 
> e4c576b911e364737b1bf4f5bfdab1c440713f26
> 
> Hopefully I did everything correct, as this is my first usage of git beside 
> checking out. Also its my first patch on lk....
> 
> Is an Signed-off-by already appropriate with such an trivial change?

Yes.

> Signed-off-by: Andres Freund <andres@...razel.de>
> ---
>  drivers/media/radio/radio-maxiradio.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/media/radio/radio-maxiradio.c 
> b/drivers/media/radio/radio-maxiradio.c
> index 0133ecf..e170fcd 100644
> --- a/drivers/media/radio/radio-maxiradio.c
> +++ b/drivers/media/radio/radio-maxiradio.c
> @@ -34,6 +34,7 @@
>  
>  
>  #include <linux/module.h>
> +#include <linux/version.h>
>  #include <linux/init.h>
>  #include <linux/ioport.h>
>  #include <linux/delay.h>

The #include is already there a dozen lines below.

It seems to be missing in another file.

Can you send the error message and your .config?

Thanks
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/