linux-kernel - Re: [2.6 patch] UTF-8 fixes in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 01 May 2008 13:18:33 -0700
From:	"H. Peter Anvin" <hpa@...nel.org>
To:	Willy Tarreau <w@....eu>
CC:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Helge Hafting <helge.hafting@...el.hist.no>,
	Adrian Bunk <bunk@...nel.org>, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [2.6 patch] UTF-8 fixes in comments

Willy Tarreau wrote:
> On Tue, Apr 29, 2008 at 11:15:54PM +0100, Alan Cox wrote:
>>> OK I could reproduce the case without ever involving either a shell or
>>> readline or anything. Using "cat" as the init program exhibited the
>>> anomaly, though it was not much easy to analyze. Then I switched to
>>> "init=od -An -tx1 -".
>> Did you put the console into utf-8 mode before the cat ?
> 
> I had not *explictly* disabled it, since as the doc suggests :
> 
>         vt.default_utf8=
>                         [VT]
>                         Format=<0|1>
>                         Set system-wide default UTF-8 mode for all tty's.
>                         Default is 1, i.e. UTF-8 mode is enabled for all
>                         newly opened terminals.
> 
> And I know that I can fix the behaviour by explicitly setting it to zero.
> Also, the fact that "od" shows me multi-byte characters on the input
> indicates to me that everything is set to UTF-8. So unless I'm missing
> something, my console is set by default to UTF-8 (I test this on 2.6.25).
> 

Yes, there is apparently a real bug here: this vt setting doesn't 
propagate to the tty layer iutf8 flag.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/