linux-kernel - Re: [PATCH 0/3] Add API for weak DMA masks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080501.143949.20091241.davem@davemloft.net>
Date:	Thu, 01 May 2008 14:39:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	alan@...rguk.ukuu.org.uk
Cc:	hch@...radead.org, mb@...sch.de, jbarnes@...tuousgeek.org,
	linville@...driver.com, andi@...stfloor.org, mingo@...e.hu,
	bcm43xx-dev@...ts.berlios.de, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] Add API for weak DMA masks

From: Alan Cox <alan@...rguk.ukuu.org.uk>
Date: Thu, 1 May 2008 17:29:13 +0100

> We have tons of drivers that go
> 
> 	try and set 64bit 
> 	oh failed
> 	try and set 32 bit
> 	oh worked
> 
> When what most actually want is "set it no more than this wide" - a
> request or even a "pci_set_best_mask()" type idea.
> 
> Lots less code duplication.

Agreed, it's a templated construct and it belongs in one
spot.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/