linux-kernel - Re: Slow DOWN, please!!!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080501014048.GC27574@elte.hu>
Date:	Thu, 1 May 2008 03:40:48 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	David Miller <davem@...emloft.net>
Cc:	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	rjw@...k.pl, linux-kernel@...r.kernel.org, jirislaby@...il.com,
	tglx@...utronix.de
Subject: Re: Slow DOWN, please!!!

* David Miller <davem@...emloft.net> wrote:

> Ingo, let me know what I need to do to change your behavior in 
> situations like the one I'm about to describe, ok?
> 
> Today, you merged in this bogus "regression fix".

the motivation of that fix wasnt UML - that was just an (indeed 
incorrect) after-thought when i wrote up the commit log. The fix is 
obviously right - although it doesnt fix UML.

btw., did you see my stream of fixes about UML?

> To an arbitrary person reading the commit logs, the above looks like 
> you fixed something, when you actually didn't fix anything.

it is wrong that it "doesnt fix anything". Look at the change itself:

- * Force always-inline if the user requests it so via the .config:
+ * Force always-inline if the user requests it so via the .config,
+ * or if gcc is too old:
  */
 #if !defined(CONFIG_ARCH_SUPPORTS_OPTIMIZED_INLINING) || \
-    !defined(CONFIG_OPTIMIZE_INLINING) && (__GNUC__ >= 4)
+    !defined(CONFIG_OPTIMIZE_INLINING) || (__GNUC__ < 4)

before the change it was only possible to disable the optimization on 
gcc 4 and above. The intended (and now implemented) condition is to only 
change anything on gcc 4 and above. I.e. on gcc3x the config option has 
no effect at all - and that's what we want.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/