linux-kernel - Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0805020610430.24733@bombadil.infradead.org>
Date:	Fri, 2 May 2008 06:15:02 -0400 (EDT)
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Arjan van de Ven <arjan@...radead.org>
cc:	Andres Freund <andres@...razel.de>, linux-kernel@...r.kernel.org,
	apdim@...cian.net
Subject: Re: [PATCH] v4l/dvb: Add linux/version.h include as KERNEL_VERSION
 macro is used.

On Thu, 1 May 2008, Arjan van de Ven wrote:

> On Thu, 1 May 2008 20:05:41 +0200
> Andres Freund <andres@...razel.de> wrote:
>
>> Whitout this build fails with unknown macro on
>> e4c576b911e364737b1bf4f5bfdab1c440713f26
>>
>> Hopefully I did everything correct, as this is my first usage of git
>> beside checking out. Also its my first patch on lk....
>>
>> Is an Signed-off-by already appropriate with such an trivial change?
>>
>
> Hi,
>
> maybe the real fix is to remove the use of KERNEL_VERSION in this code??

This is one of the rare cases where the usage of KERNEL_VERSION is valid. 
This is the code there:

#include <linux/version.h>      /* for KERNEL_VERSION MACRO     */
#define RADIO_VERSION KERNEL_VERSION(0,7,7)

This macro is required by V4L API to indicate the module version.

One possible solution would be to fork KERNEL_VERSION into something like 
V4L_VERSION, and replace it on drivers/media/video/* and 
drivers/media/radio/*.

Yet, I'm not sure if it would be nice to have two macros with the same 
code.

-- 
Cheers,
Mauro Carvalho Chehab
http://linuxtv.org
mchehab@...radead.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/