linux-kernel - Re: huge gcc 4.1.{0,1} _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080502104348.GC20741@uranus.ravnborg.org>
Date:	Fri, 2 May 2008 12:43:48 +0200
From:	Sam Ravnborg <sam@...nborg.org>
To:	Alistair John Strachan <alistair@...zero.co.uk>
Cc:	Chris Knadle <Chris.Knadle@...edump.us>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Adrian Bunk <bunk@...nel.org>, venkatesh.pallipadi@...el.com,
	davem@...emloft.net, trini@...nel.crashing.org, mingo@...e.hu,
	tglx@...utronix.de, hpa@...or.com, linux-kernel@...r.kernel.org,
	suresh.b.siddha@...el.com,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: huge gcc 4.1.{0,1} __weak problem

On Fri, May 02, 2008 at 10:55:09AM +0100, Alistair John Strachan wrote:
> Hi Chris,
> 
> (I fixed the corrupted CC and Reply-to: address from your email.)
> 
> On Friday 02 May 2008 00:55:58 Chris Knadle wrote:
> > On Thu, 1 May 2008, Linus Torvalds wrote:
> > > On Thu, 1 May 2008, Andrew Morton wrote:
> > > > > I see only the following choices:
> > > > > - remove __weak and replace all current usages
> > > > > - move all __weak functions into own files, and ensure that also
> > > > > happens for future usages
> > > > > - #error for gcc 4.1.{0,1}
> > > >
> > > > Can we detect the {0,1}?  __GNUC_EVEN_MORE_MINOR__?
> > >
> > > It's __GNUC_PATCHLEVEL__, I believe.
> > >
> > > So yes, we can distinguish 4.1.2 (good, and very common) from 4.1.{0,1}
> > > (bad, and rather uncommon).
> > > And yes, considering that 4.1.1 (and even more so 4.1.0) should be rare
> > > to begin with, I think it's better to just not support it.
> > >
> > >			Linus
> >
> >    Unfortunately Debian Stable (i.e. Etch), which is relatively popular for
> > server use, is still using 4.1.1  :-(  (The current gcc package is
> > gcc-4.1.1-21)
> >
> >    I have not looked to see if Debian Stable's gcc-4.1.1-21 has been
> > patched for the currently discussed __weak bug.
> 
> I checked and it has been patched in 4.1.1-21. This would make checking for 
> 4.1.1 via __GNUC_PATCHLEVEL__ potentially invalid, as patched distro 
> compilers may (and in this case do) have this fixed.

Is it possible to cook up a small sample file we could build as part
of the kernel build. If it fails => error out.
If someone comes up with the code I shall try to integrate it
in the build system.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/