linux-kernel - Re: Horrendous Audio Stutter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1209729063.13978.152.camel@twins>
Date:	Fri, 02 May 2008 13:51:03 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Frans Pop <elendil@...net.nl>
Cc:	Parag Warudkar <parag.warudkar@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Horrendous Audio Stutter - current git

On Fri, 2008-05-02 at 13:45 +0200, Frans Pop wrote:
> On Friday 02 May 2008, Peter Zijlstra wrote:
> > On Fri, 2008-05-02 at 13:37 +0200, Frans Pop wrote:
> > > On Friday 02 May 2008, Peter Zijlstra wrote:
> > > > > Ok, that's _WAY_ too big, something went seriously wrong. Thanks!
> > > >
> > > > In fact, that is exactly 1024 time too large.
> > > >
> > > > How does this work for you:
> > >
> > > Changes nothing. Values of bonus_max are unchanged and still skips.
> >
> > Humm, I saw some bonus_max spikes on my laptop which were fixed by that
> > patchlet, ah well, the hunt goes on.
> 
> Oh! Hang on. I just checked and saw that I made the change in 
> dequeue_entity() instead of enqueue_entity(). Let me try again.
> 
> For code symmetry I guess both should probably be changed?

Symetry would actually make it something like:

enqueue()
  A
  B
  C

dequeu()
  C
  B
  A

But I just quickly checked the code and I can't see any ill effect of
mis-placing that code in dequeue() too.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/