linux-kernel - [PATCH 2.6.26 2/3] RDMA/cxgb3: Silently ignore close reply after abort.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080502161743.30500.27928.stgit@dell3.ogc.int>
Date:	Fri, 02 May 2008 11:17:43 -0500
From:	Steve Wise <swise@...ngridcomputing.com>
To:	rdreier@...co.com
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	general@...ts.openfabrics.org
Subject: [PATCH 2.6.26 2/3] RDMA/cxgb3: Silently ignore close reply after abort.


Remove bad BUG_ON() in close_con_rpl().  It is possible to get a close_rpl
message on a dead connection.  The sequence is:
	host refs ep for close exchange
	host posts close_req
	hw posts PEER_ABORT from incoming RST
	host marks ep DEAD
	host posts ABORT_RPL and releases ep resources
	hw posts CLOSE_RPL
	host derefs ep and ep freed.

Signed-off-by: Steve Wise <swise@...ngridcomputing.com>
---

 drivers/infiniband/hw/cxgb3/iwch_cm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index f4f3c9e..b2db0a9 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -1650,8 +1650,8 @@ static int close_con_rpl(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
 		release = 1;
 		break;
 	case ABORTING:
-		break;
 	case DEAD:
+		break;
 	default:
 		BUG_ON(1);
 		break;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/