linux-kernel - Re: [PATCH] Extend list debugging to cover hlists

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 2 May 2008 15:05:01 -0400
From:	Dave Jones <davej@...emonkey.org.uk>
To:	Matthew Wilcox <matthew@....cx>
Cc:	Arjan van de Ven <arjan@...radead.org>,
	Linus Torvalds <torvalds@...l.org>,
	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Extend list debugging to cover hlists

On Fri, May 02, 2008 at 12:49:22PM -0600, Matthew Wilcox wrote:
 > On Thu, May 01, 2008 at 01:32:09PM -0700, Arjan van de Ven wrote:
 > > I like the concept of the patch; however...
 > > BUG() is a tad on the rude side... how about WARN_ON(1) ?
 > 
 > I'm just copying the conventions of the code above.  If those should be
 > WARN_ON(1) then that should be a followup patch.

No objections from me either way.  I chose to BUG originally because
the bug I was chasing was corrupting memory in such a way that we'd
die horribly shortly afterwards anyway.

	Dave

-- 
http://www.codemonkey.org.uk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/