linux-kernel - Re: huge gcc 4.1.{0,1} _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080502.150243.146424084.davem@davemloft.net>
Date:	Fri, 02 May 2008 15:02:43 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jeremy@...p.org
Cc:	suresh.b.siddha@...el.com, torvalds@...ux-foundation.org,
	venkatesh.pallipadi@...el.com, trini@...nel.crashing.org,
	akpm@...ux-foundation.org, bunk@...nel.org, mingo@...e.hu,
	tglx@...utronix.de, hpa@...or.com, linux-kernel@...r.kernel.org
Subject: Re: huge gcc 4.1.{0,1} __weak problem

From: Jeremy Fitzhardinge <jeremy@...p.org>
Date: Fri, 02 May 2008 14:11:18 -0700

> Suresh Siddha wrote:
> > On Thu, May 01, 2008 at 05:34:34PM -0700, Linus Torvalds wrote:
> >   
> >> Is it always about inlining? If so, can't we add a __noinline__ to the 
> >> declaration of __weak?
> >>     
> >
> > We tried that and it was still getting inlined.
> 
> That's a pity.  I've worked around this bug with noinline before.

It's "constness", as Jakub mentioned, not inlineability, that triggers
this bug.

That's why his workaround of using an empty asm("") to the function is
an effective workaround, because the compiler can no longer internally
decide that the function is "const".
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/