linux-kernel - [patch/bugreport] rt2x00: build fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080503124711.GA18244@elte.hu>
Date:	Sat, 3 May 2008 14:47:11 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	linux-kernel@...r.kernel.org
Cc:	"David S. Miller" <davem@...emloft.net>,
	Ivo van Doorn <ivdoorn@...il.com>
Subject: [patch/bugreport] rt2x00: build fix


x86.git testing found the following build failure on latest -git:

   Building modules, stage 2.
   MODPOST 332 modules
 ERROR: "led_classdev_unregister" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
 ERROR: "led_classdev_resume" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
 ERROR: "led_classdev_register" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
 ERROR: "led_classdev_suspend" [drivers/net/wireless/rt2x00/rt2x00lib.ko] undefined!
 make[1]: *** [__modpost] Error 1
 make: *** [modules] Error 2

config can be found at:

  http://redhat.com/~mingo/misc/config-Sat_May__3_13_24_19_CEST_2008.bad

the patch here is just a quick workaround for now for my test-setup, it 
makes the leds features in this driver depend on NEW_LEDS. Have not 
checked how far away this is from the real fix. Hm, and i think think i 
sent another patch for a similar build failure a week ago already - did 
i miss some patch to try?

	Ingo

---
 drivers/net/wireless/rt2x00/Kconfig |    5 +++++
 1 file changed, 5 insertions(+)

Index: linux/drivers/net/wireless/rt2x00/Kconfig
===================================================================
--- linux.orig/drivers/net/wireless/rt2x00/Kconfig
+++ linux/drivers/net/wireless/rt2x00/Kconfig
@@ -61,6 +61,7 @@ config RT2400PCI_RFKILL
 config RT2400PCI_LEDS
 	bool "RT2400 leds support"
 	depends on RT2400PCI
+	depends on NEW_LEDS
 	select LEDS_CLASS
 	select RT2X00_LIB_LEDS
 	---help---
@@ -88,6 +89,7 @@ config RT2500PCI_RFKILL
 config RT2500PCI_LEDS
 	bool "RT2500 leds support"
 	depends on RT2500PCI
+	depends on NEW_LEDS
 	select LEDS_CLASS
 	select RT2X00_LIB_LEDS
 	---help---
@@ -117,6 +119,7 @@ config RT61PCI_RFKILL
 config RT61PCI_LEDS
 	bool "RT61 leds support"
 	depends on RT61PCI
+	depends on NEW_LEDS
 	select LEDS_CLASS
 	select RT2X00_LIB_LEDS
 	---help---
@@ -134,6 +137,7 @@ config RT2500USB
 config RT2500USB_LEDS
 	bool "RT2500 leds support"
 	depends on RT2500USB
+	depends on NEW_LEDS
 	select LEDS_CLASS
 	select RT2X00_LIB_LEDS
 	---help---
@@ -153,6 +157,7 @@ config RT73USB
 config RT73USB_LEDS
 	bool "RT73 leds support"
 	depends on RT73USB
+	depends on NEW_LEDS
 	select LEDS_CLASS
 	select RT2X00_LIB_LEDS
 	---help---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/