linux-kernel - Re: [PATCH 1/2] OF: clean coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <481C9FFB.3090207@gmail.com>
Date:	Sat, 03 May 2008 19:25:15 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	monstr@...nam.cz
CC:	paulus@...ba.org, arnd@...db.de, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 1/2] OF: clean coding style - prom_parse.c

On 05/03/2008 05:13 PM, monstr@...nam.cz wrote:
> From: Michal Simek <monstr@...str.eu>
> 
> 
> Signed-off-by: Michal Simek <monstr@...str.eu>
> ---
>  arch/powerpc/kernel/prom_parse.c |   98 ++++++++++++++++++--------------------
>  1 files changed, 46 insertions(+), 52 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/prom_parse.c b/arch/powerpc/kernel/prom_parse.c
> index 90eb3a3..7c6b07c 100644
> --- a/arch/powerpc/kernel/prom_parse.c
> +++ b/arch/powerpc/kernel/prom_parse.c
> @@ -31,21 +25,19 @@ static int __of_address_to_resource(struct device_node *dev,
>  		const u32 *addrp, u64 size, unsigned int flags,
>  		struct resource *r);
>  
> -
>  /* Debug utility */
>  #ifdef DEBUG
>  static void of_dump_addr(const char *s, const u32 *addr, int na)
>  {
> -	printk("%s", s);
> -	while(na--)
> -		printk(" %08x", *(addr++));
> -	printk("\n");
> +	printk(KERN_INFO "%s", s);
> +	while (na--)
> +		printk(KERN_INFO " %08x", *(addr++));
> +	printk(KERN_INFO "\n");

This is wrong you'll get
string <6> XXXXXXXX <6> XXXXXXX ... <6>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/