linux-kernel - Re: [PATCH 1/1] DEBUGFS: Fixing name for debug fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200805032307.04352.arnd@arndb.de>
Date:	Sat, 3 May 2008 23:07:03 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	monstr@...nam.cz
Cc:	paulus@...ba.org, linux-kernel@...r.kernel.org,
	linux-arch@...r.kernel.org, Michal Simek <monstr@...str.eu>
Subject: Re: [PATCH 1/1] DEBUGFS: Fixing name for debug fs

On Saturday 03 May 2008, monstr@...nam.cz wrote:
> From: Michal Simek <monstr@...str.eu>
> 
> This change is made because powerpc_debugfs_root is arch
> specific name.
...
>  
>  static int powerpc_debugfs_init(void)
>  {
> -       powerpc_debugfs_root = debugfs_create_dir("powerpc", NULL);
> +       debugfs_root = debugfs_create_dir("powerpc", NULL);
>  

You left the name as "powerpc", which sort of defeats the purpose of your
patch. Files in debugfs are by definition not part of the ABI, so it's
actually possible to change this as well. How about making this "of"
instead of "powerpc"?

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/