linux-kernel - Re: git trees which are not yet in linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 03 May 2008 00:52:10 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux-next@...r.kernel.org, sfrench@...ibm.com,
	swhiteho@...hat.com, ralf@...ux-mips.org, drzeus-list@...eus.cx,
	jack@....cz, cbou@...l.ru, jens.axboe@...cle.com, ericvh@...il.com,
	wim@...ana.be, chris@...kel.net, nico@....org,
	penberg@...helsinki.fi, clameter@....com, ezk@...sunysb.edu,
	linux-kernel@...r.kernel.org
Subject: Re: git trees which are not yet in linux-next

Andrew Morton wrote:
> On Sat, 03 May 2008 03:19:00 +0200 Stefan Richter <stefanr@...6.in-berlin.de> wrote:
> 
>> Andrew Morton wrote:
>>> On Fri, 2 May 2008 15:12:06 -0700
>>> Andrew Morton <akpm@...ux-foundation.org> wrote:
>>>
>>>> The first
>>>> problem is working out "how the heck did that patch get into linux-next"? 
>>>> That would be much easier if the signoff trail was complete for git-based
>>>> patches, but it often is not.
>>> doh.  I'm pulling linux-next's constituent trees independently, so if I
>>> spot a turd in linux-next I can just grep the various git trees to find out
>>> where it came from.
>>>
>>> It seems wrong though...
>> What about the committer info?  Well, I suppose a nobody@...alhost slips 
>> in, but more often I expect it to be something more telling than that.
> 
> Beats me.  To pick one example:
> 
> commit 1a72963d3af38eb17a939fc19b322735da1c0aad
> Author: Matthew Wilcox <matthew@....cx>
> Date:   Fri Apr 25 12:38:41 2008 -0400
> 
>     Convert board-nokia770 from semaphore to spinlock
>     
>     None of the operations done under the semaphore could sleep, so a spinlock
>     is more appropriate to this case.
>     
> Signed-off-by: Matthew Wilcox <willy@...ux.intel.com>
> 
> There's no sign how that got there.  A bit of forensics shows up:

Poke through the man pages, particularly git-log, and tell it to spit 
out the committer info, then.  It's in there.

For example,

	git log --pretty=full

produces

	commit c4d0f8cbca3a97900f85b082064a63c7a5928bd7
	Author: Alan Cox <alan@...rguk.ukuu.org.uk>
	Commit: Greg Kroah-Hartman <gregkh@...e.de>

	    usb_serial: some coding style fixes

	    Signed-off-by: Alan Cox <alan@...hat.com>
	    Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

Regards,

	Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/